Changeset 2751

Timestamp:

11/07/07 15:49:15 (1 year ago)

Author:

gt4329b

Message:

fixed to work with Postgres: the _ensure_user_data method was using an INSERT IGNORE statement, which is not support SQL in Postgres. Modified the method to grab a list of known users from session_attribute and only do an insert for any that aren't already present. Really this is an optimization *and* a bugfix, as the 99.9% of the time situation the initial SELECT is all that will be performed per ticket page load, which will be a heck of a lot faster than a whole slew of INSERT IGNOREs (or the equivalent) that just fall through.

Files:

• flexibleassigntoplugin/0.11/trunk/flexibleassignto/flexibleassignto.py (modified) (3 diffs)

flexibleassigntoplugin/0.11/trunk/flexibleassignto/flexibleassignto.py

@@ -13 +13 @@
-## python imports
-from pprint import pprint, pformat
+import psycopg2 #import IntegrityError
-
-## trac imports
@@ -208 +209 @@
-        return _tag
-
+    def _get_allusers_session_info(self, cnx):
+        """
+        """
+        cursor = cnx.cursor()
+        cursor.execute('''
+            SELECT DISTINCT n.sid AS sid, n.value AS name, e.value AS email
+            FROM session_attribute AS n 
+             LEFT JOIN session_attribute AS e ON (e.sid=n.sid
+                AND e.authenticated=1 AND e.name = 'email')
+            WHERE n.authenticated=1 
+                AND n.name = 'name'
+            ORDER BY n.sid''')
+        for username,name,email in cursor:
+            yield username, name, email        
+
-    def _ensure_user_data(self, users):
-        """
@@ -214 +230 @@
-        values for 'name' or 'email'.
-        """
-OR IGNORE 
+
-            (sid, authenticated, name, value) 
-"%s", 1, "email" , "%s"
-OR IGNORE 
+'%s', 1, 'email' , '%s'
+
-            (sid, authenticated, name, value) 
-"%s", 1, "name" , "%s"
+'%s', 1, 'name' , '%s'
-        db = self.env.get_db_cnx()
-        cursor = db.cursor()
+        known_users = self._get_allusers_session_info(db)
+        known_usernames = [u[0] for u in known_users]
-        for u in users:
-            _username = str(u.getUsername()).strip()
-            _email = str(u.email).strip()
-            _fullname = str(u.fullname).strip()
-
+
+
-                if u.email and _email != '':
-
+
+
+
+
-                if u.fullname and _fullname != '':
-
-
+
+
+
+
+
-        cursor.close()
-