Changeset 70

Timestamp:

07/18/05 08:04:57 (3 years ago)

Author:

athomas

Message:

AdminConsoleProviderPatch:

• Moved !IAdminConsoleProvider extension implementations into distinct classes.
  

Files:

• adminconsoleproviderpatch/trunk/admin-provider-refactor.diff (modified) (7 diffs)

adminconsoleproviderpatch/trunk/admin-provider-refactor.diff

@@ -11 +11 @@
- class MyLinkResolver(Component):
-     """
-
-
-
-
-
-
-
-
-
-
+
-             return '<a class="missing ticket" href="%s" rel="nofollow">%s</a>' \
-                    % (formatter.href.ticket(target), label)
- 
--    
++
++class TicketAdminConsole(Component):
++    """ Provides trac-admin with ticket related commands """
++
-+    # IAdminConsoleProvider methods
++    implements(IAdminConsoleProvider)
-+
-+    def get_console_commands(self, tracadm):
@@ -292 +288 @@
-+        rows = self.db_query("SELECT name FROM version")
-+        return [row[0] for row in rows]
++
-Index: trac/Milestone.py
-===================================================================
@@ -306 +303 @@
- 
-     def __init__(self, env, name=None, db=None):
-
-
-
-
-
-
-
-
-
-
+
-     def _format_link(self, formatter, ns, name, label):
-         return '<a class="milestone" href="%s">%s</a>' \
-                % (formatter.href.milestone(name), label)
++
++
++class MilestoneAdminConsole(Component):
++    """ Provide trac-admin with commands for manipulating milestones """
++
++    implements(IAdminConsoleProvider)
-+
-+    # IAdminConsoleProvider methods
@@ -1275 +1269 @@
-            'IPermissionGroupProvider', 'PermissionError', 'PermissionSystem']
- 
-
-
-
-
-
-
-
-
-
-
+
-                     actions.append(action)
-         return [('TRAC_ADMIN', actions)]
- 
++
+     # Internal methods
+ 
+     def _get_store(self):
+@@ -178,6 +180,8 @@
+     store = property(fget=lambda self: self._get_store())
+ 
+ 
++
++
+ class IPermissionGroupProvider(Interface):
+     """
+     Extension point interface for components that provide information about user
+@@ -289,3 +293,90 @@
+ 
+     def permissions(self):
+         return self.perms.keys()
++
++
++class PermissionAdminConsole(Component):
++    """ Provides trac-admin permission commands """
++
++    implements(IAdminConsoleProvider)
++
-+    # IAdminConsoleProvider methods
-+
@@ -1368 +1377 @@
-+            sql += " WHERE " + " AND ".join(clauses)
-+        self.tracadm.db_update(sql)
-+
-+
-     # Internal methods
- 
-     def _get_store(self):
-Index: trac/wiki/api.py
-===================================================================
@@ -1389 +1393 @@
-     """
-     Extension point interface for components that should get notified about the
-13 +85,11
+8 +85,6
-         """
-         Return an iterable over (namespace, formatter) tuples.
@@ -1398 +1402 @@
-     """
-     Represents the wiki system.
-
-
-
-
-
-
-
+
-             return '<a class="wiki" href="%s">%s</a>' \
-                    % (formatter.href.wiki(page) + anchor, label)
- 
++
++class WikiAdminConsole(Component):
++    """ Provide trac-admin with wiki commands """
++    
++    implements(IAdminConsoleProvider)
++
-+    # IAdminConsoleProvider methods
-+