Ticket #1079 (closed enhancement: wontfix)

Opened 2 years ago

Last modified 1 year ago

Use link under the View Tickets tab instead of Custom Query tab

Reported by: anonymous Assigned to: tonin
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords: navigation tab
Cc: Trac Release: 0.10

Description

Adding yet another tab in the navigation bar can become problematic for any user having the TRAC_ADMIN permissions: the navigation bar becomes too long.

Wouldn't it be possible to use the same Custom Query link below the View Tickets link as in the default Trac behaviour ?

Attachments

Change History

01/08/07 12:48:04 changed by tonin

  • owner changed from b to ashwin_phatak.

03/02/07 14:50:39 changed by anonymous

It would be great if this ticket could be fixed, Im getting a way to long nav menu.

05/16/07 12:59:20 changed by tonin

  • owner changed from ashwin_phatak to tonin.
  • status changed from new to assigned.

The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule class (see trac/ticket/report.py code): 

# Kludge: only show link to custom query if the query module is actually
# enabled
from trac.ticket.query import QueryModule
if req.perm.has_permission('TICKET_VIEW') and \
   self.env.is_component_enabled(QueryModule):
    req.hdf['report.query_href'] = req.href.query()

We see a direct test to the QueryModule to see if it's enabled.. However, the BatchModifyModule needs the QueryModule to be disabled to work. :(

To solve this problem, one should patch Trac, which is not so recommended, or make the BatchModifyModule behave like if it was the QueryModule which is enabled. Not sure how this last option is feasable. Anyone has a clue?

11/12/07 18:29:12 changed by coling

  • status changed from assigned to closed.
  • resolution set to wontfix.

This is solved in 0.11 via the use of a filter to adjust the output of the built in query page rather than actually create it's own one.

It would be pretty tricky to fix it properly for 0.10 without some kind of ugly hack or patch to Trac itself. So I think this can be closed...

If someone feels strongly to the contrary, please reopen.

Add/Change #1079 (Use link under the View Tickets tab instead of Custom Query tab)




Change Properties
Action