Ticket #1749 (assigned enhancement)

Opened 1 year ago

Last modified 4 months ago

0.11 support for deleteticket

Reported by: phpxcache@gmail.com Assigned to: asmodai (accepted)
Priority: normal Component: TicketDeletePlugin
Severity: blocker Keywords:
Cc: benoitg@coeus.ca, gregoryba@gmail.com, datallah@pidgin.im Trac Release: 0.11

Description

0.11 support for deleteticket

Attachments

ticketdelete-trac0.11.patch (13.3 kB) - added by phpxcache on 07/07/07 05:34:31.
ticketdelete-trac0.11-v2.patch (13.3 kB) - added by s0undt3ch on 07/10/07 12:21:05.
Actual patch from svn, no copy/paste
ticketdelete-trac0.11-v3.patch (12.6 kB) - added by hkaimio on 12/06/07 06:20:12.
new version, tested with trac 0.11 r6202
ticketdelete-trac0.11-v4.patch (7.4 kB) - added by kkckkc on 04/17/08 06:19:48.
Patch tested against r3519
ticketdeleteplugin_timestamp_fix.patch (1.2 kB) - added by jonas@edgewall.com on 04/22/08 16:35:47.
Asmodai this appears to fix the timestamp issue on t.e.o we talked about yesterday
trac-0.11-okamototk.patch (8.0 kB) - added by anonymous on 07/27/08 19:14:25.
patch for 0.11 by okamototk
ticketdeleteplugin_0.11_working.patch (62.1 kB) - added by daniel on 08/03/08 02:01:09.
Patch to implement the button with a ITemplateStreamFilter and make the plugin work fully

Change History

07/07/07 05:34:31 changed by phpxcache

  • attachment ticketdelete-trac0.11.patch added.

07/07/07 05:35:49 changed by phpxcache

  • release changed from 0.10 to 0.11.

07/10/07 12:21:05 changed by s0undt3ch

  • attachment ticketdelete-trac0.11-v2.patch added.

Actual patch from svn, no copy/paste

(follow-up: ↓ 3 ) 07/10/07 12:23:03 changed by s0undt3ch

I re-added the v2 patch because the first one was a copy/paste on a remote machine and might introduce apply problems.

(in reply to: ↑ 2 ) 07/12/07 08:53:24 changed by s0undt3ch

  • type changed from defect to enhancement.
  • severity changed from normal to blocker.

Replying to s0undt3ch:

I re-added the v2 patch because the first one was a copy/paste on a remote machine and might introduce apply problems.

This version still fails to delete ticket changes, ie, it only works for deleting complete tickets.

12/06/07 06:20:12 changed by hkaimio

  • attachment ticketdelete-trac0.11-v3.patch added.

new version, tested with trac 0.11 r6202

12/06/07 06:21:10 changed by hkaimio

New ersion of the patch that works with the current 0.11 tree.

01/24/08 11:58:52 changed by anonymous

i install deleteticket on trac 0.11 via 

easy_install http://trac-hacks.org/svn/ticketdeleteplugin/0.11/

Installation Works but no menu on the Admin page and i have the following error on the log: 

ERROR: Skipping "ticketdelete.web_ui = ticketdelete.web_ui": (can't import "No module named webadmin.web_ui")

Thanks for Helping

02/04/08 11:38:34 changed by ross

hkaimio,

even with your latest patch ticketdelete-trac0.11-v3.patch it still does not work on 0.11 for deleting ticket changes:

Trac detected an internal error: TypeError?: object of type 'Undefined' has no len()

File "C:\Documents and Settings\LocalService?\Application Data\Python-Eggs\tracticketdelete-2.0-py2.5.egg-tmp\ticketdelete\templates\ticketdelete_admin.html", line 34, in <Expression u'len(ticketdelete.changes)'>

Do youknow what is the case.

Would be great if soeone puts the fully working TicketDeletePlugin for 0.11 It's rally very useful.

02/25/08 09:45:06 changed by anonymous

  • cc set to benoitg@coeus.ca.

03/21/08 21:41:21 changed by gregoryba@gmail.com

  • cc changed from benoitg@coeus.ca to benoitg@coeus.ca, gregoryba@gmail.com.

there's a traceback of an error with 0.11 over at #2781, might or might not be related.

04/17/08 06:19:48 changed by kkckkc

  • attachment ticketdelete-trac0.11-v4.patch added.

Patch tested against r3519

04/17/08 06:21:32 changed by kkckkc

I've attached a patch against r3519 that seem to be working fine with 0.11

The path also enables some attachment deletion, but use this with care. I haven't really tested this

04/17/08 14:15:25 changed by asmodai

  • owner changed from coderanger to asmodai.
  • status changed from new to assigned.

Committed patch v4 in r3526.

04/22/08 16:35:47 changed by jonas@edgewall.com

  • attachment ticketdeleteplugin_timestamp_fix.patch added.

Asmodai this appears to fix the timestamp issue on t.e.o we talked about yesterday

04/23/08 14:30:43 changed by asmodai

Committed in r3542.

04/23/08 14:31:43 changed by asmodai

Err, make that r3543.

07/27/08 19:13:34 changed by anonymous

TicketDeletePlugin doesn't work yes.

I attached additional patch for 0.11(trac-0.11-okamototk.patch).

regards,

Takashi Okamoto

07/27/08 19:14:25 changed by anonymous

  • attachment trac-0.11-okamototk.patch added.

patch for 0.11 by okamototk

08/03/08 02:01:09 changed by daniel

  • attachment ticketdeleteplugin_0.11_working.patch added.

Patch to implement the button with a ITemplateStreamFilter and make the plugin work fully

08/03/08 02:11:33 changed by datallah

I attached a patch which brings this plugin fully up to date with 0.11 as far as I can tell. Both the overall ticket deletion and the change deletion pages appear to work correctly, including linking from Delete buttons on the ticket screen.

I wish I had seen this ticket before starting working on this as it would have saved me some time.

Some of the changes I made in addition to the bug fixes:

  • The adding of the buttons has been updated to a ITemplateStreamFilter to !add them as the page is being rendered on the server instead of adding them with javascript. (thanks to aat for helping me figure out how to do this)
  • Make the "back" button link to the referrer screen instead of always the !admin screen

08/03/08 02:54:30 changed by datallah

  • cc changed from benoitg@coeus.ca, gregoryba@gmail.com to benoitg@coeus.ca, gregoryba@gmail.com, datallah@pidgin.im.

Add/Change #1749 (0.11 support for deleteticket)




Change Properties
Action