Ticket #1799 (new defect)

Opened 1 year ago

Last modified 3 months ago

{p1} doesn't work as expected and :\ is not a good smiley IMHO

Reported by: kennethxu Assigned to: cboos
Priority: low Component: WikiGoodiesPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

I think it's very common that I write things like C:\Temp. I prefer to use :-\ instead.

It was {1} in the code, but I couldn't get {p1} to work neither. {#1} works for me.

I have attached the updated smileys.py file.

Attachments

smileys.py (2.5 kB) - added by kennethxu on 07/16/07 11:25:17.
1799.patch (1.4 kB) - added by kennethxu on 09/28/08 13:36:35.
Patch for both 0.9/0.10 and 0.11 to fix the :\ and {1}

Change History

07/16/07 11:25:17 changed by kennethxu

  • attachment smileys.py added.

07/16/07 12:21:04 changed by kennethxu

BTW, the platform is Windows 2003 Server, python 2.5.1, trac 0.10.4

07/17/07 00:59:39 changed by cboos

  • priority changed from normal to low.

Well, the r2439 and r2444 changes were for the 0.11-compatible version of the plugin.

Those changes could eventually be backported to the 0.9 branch (which is also 0.10-compatible).

Patch welcomed ;-)

01/02/08 04:17:12 changed by Maverick

How can you escape smileys? I'm having problems with the :/ smiley because I have alot of C:\Bla\Bla paths at my wiki page.

01/02/08 04:17:39 changed by anonymous

:\ smiley *

09/28/08 13:35:19 changed by kennethxu

:\ is fixed in 0.11, seems that it requires a space before : to be qualified as a smiley in 0.11.

But {p1} still doesn't work. Not sure if it is environement related, but we use Windows Server 2003, Python 2.5.2 and Track 0.11.1. I had to use {#1} instead.

I am enclosing the patch for both 0.9 and 0.11 to resolve this problem. Anybody used the smiley.py will need this patch to make everything working in 0.11

09/28/08 13:36:35 changed by kennethxu

  • attachment 1799.patch added.

Patch for both 0.9/0.10 and 0.11 to fix the :\ and {1}

Add/Change #1799 ({p1} doesn't work as expected and :\ is not a good smiley IMHO)




Change Properties
Action