Attach changeset to Code Review

I'd like to add my vote for this - it's impractical to enter each range of changed lines in each file. The changeset already has this information. Even better than a changeset might be to be able to select a range of revision numbers related to a folder - similar to the TortoiseSVN merge screen which allows you to merge between branches.

As an extension it'll be usefull to enter several files or even directory to make a full review (no need to enter the lines), for example for a review of a whole component

So at least a changeset will be A LOT usefull ! So I vote for this enhancement

This is a great idea

Has anyone made any progress on this ticket? Is anyone planning to? I've seen this mentioned as a blocker to people using this plugin in a few places (e.g. here); it is certainly the main problem I would have with using it.

From a quick look at the code, the work required to get a useable solution shouldn't be very hard. Here's what I propose. We simply add a "create review from changeset" option to the "create new code review" page, which has two user inputs: a text box for the revision number, and a "add files from this changeset" button. When the user presses the button, the data for that changeset is retrieved and entered in the page. In /peerreviewplugin/branches/2.2-dev/codereview/peerReviewNew.py, it looks like the data would be added as is done around lines 89 and 144, and changeset data could be retrieved using methods from here

repos.get_changesets(old,new)

With line numbers worked out as _content_changes here.

Indeed, line numbers would be optional, and a first step would be just to retrieve the file names. This would give minimal working functionality, and quickly. There are a few things I don't know until I try it:

• What to do if (and whether to allow) the user adds data from multiple changesets? Should the diffs merge?
• How/whether to link a review back to the changeset it was reviewing.
• How well it would work with non-svn repositories

I only installed the PeerReviewPlugin earlier today so I'm no expert, and I'm not sure if this is a reasonable design. Any thoughts?

I'm very interested in this feature aswell. Is it possible to resolve attaching changeset to code review in any way ?

I just came across this module and I was hoping that it would have this particular feature.

sontek, if you don't have time to implement it yourself perhaps you could give some guidance as to where in the code someone would start trying to make a patch?

Wow. Three years, and no action.