Ticket #2612 (new enhancement)

Opened 9 months ago

Last modified 6 months ago

Port of SvnAuthzAdminPlugin to 0.11

Reported by: danimo Assigned to: kisg
Priority: normal Component: SvnAuthzAdminPlugin
Severity: normal Keywords: 0.11, port
Cc: Trac Release: 0.11

Description

During a project for university we have ported SvnAuthzAdminPlugin to trac 0.11. Attached is the diff to the latest Version for 0.10:

Major changes:

- Adjustments to 0.11 API - Ported Templates to Genshi - Removed dependency on AccountManager plugin (used 0.11 admin infrastructure instead)

This patch probably needs some cleanups, but works for us (tm).

Attachments

svnauthzadminplugin_for_trac0.11.diff (29.2 kB) - added by danimo on 02/20/08 07:16:19.
revisedPatch.diff (16.3 kB) - added by gkruse@gmail.com on 03/24/08 13:58:35.
Fixed r/w checkboxes
revisedPatch.2.diff (29.2 kB) - added by gkruse@gmail.com on 03/24/08 14:02:14.
Fixed r/w checkboxes (forgot the critical section)
fix-checkboxes.diff (1.4 kB) - added by olaf.meeuwissen@avasys.jp on 04/11/08 03:00:36.
isolated R/W checkbox fix in separate patch

Change History

02/20/08 07:16:19 changed by danimo

  • attachment svnauthzadminplugin_for_trac0.11.diff added.

02/20/08 07:18:51 changed by danimo

  • release changed from 0.10 to 0.11.
  • summary changed from Port of SvnAuthzAdminPlugin to Port of SvnAuthzAdminPlugin to 0.11.

03/24/08 13:57:27 changed by gkruse@gmail.com

I tried this patch and it worked beautifully with one exception. The code in the template that decides if the r/w checkboxes are checked or not seems to be broken. This results in both the r and w checkboxes always being checked regardless of the actual permissions. Please see the revised patch for my quick fix, however, I don't know enough genshi to know if this is the best way to fix it or not.

03/24/08 13:58:35 changed by gkruse@gmail.com

  • attachment revisedPatch.diff added.

Fixed r/w checkboxes

03/24/08 14:02:14 changed by gkruse@gmail.com

  • attachment revisedPatch.2.diff added.

Fixed r/w checkboxes (forgot the critical section)

03/24/08 14:04:15 changed by gkruse@gmail.com

Please see lines 183-194 of admin_authz.html in revisedPatch.2.diff

04/11/08 03:00:36 changed by olaf.meeuwissen@avasys.jp

  • attachment fix-checkboxes.diff added.

isolated R/W checkbox fix in separate patch

04/11/08 03:05:39 changed by olaf.meeuwissen@avasys.jp

I had a look at the three patches and got a bit confused at first. After looking over the patches, I finally figured out what those revised patches were trying to achieve. I've isolated the fixes in a separate patch. Now you can patch the 0.10 sources as follows:

That should fix the checkbox problem without patch complaining all over the place ;-).

(follow-up: ↓ 6 ) 04/16/08 19:16:44 changed by envertigo

What would I use to merge that diff file? TortoiseSVN doesn't want to apply it.

(in reply to: ↑ 5 ) 04/16/08 19:29:58 changed by olaf.meeuwissen@avasys.jp

Replying to envertigo:

What would I use to merge that diff file? TortoiseSVN doesn't want to apply it.

I have no experience with TortoiseSVN, but I noticed that I may have goofed up the path in the diffs. In order to apply cleanly with patch, you would do: 

cd /path/to/svnauthzadminplugin
patch -p0 < svnauthzadminplugin_for_trac0.11.diff
patch -p1 < fix-checkboxes.diff

Note the difference in the number of leading path components that are stripped.

Maybe TortoiseSVN has an option that lets's you specify this? I dunno.

05/12/08 17:51:02 changed by anonymous

  • type changed from defect to enhancement.

Is there an official release for Trac 0.11?

Or, we have to apply patches as others mentioned above?

(follow-up: ↓ 9 ) 05/28/08 09:34:59 changed by knox

I get the following error and dont know how whats wrong. 

ParseError: ParseError: [/var/www/trac/.tmp/SvnAuthzAdminPlugin-0.1-py2.5.egg-tmp/svnauthz/templates/admin_authz.cs:14] Undefined macro called: hdf_select(editgroup.candidates, "subject", "", 0)

(in reply to: ↑ 8 ) 05/28/08 10:33:32 changed by anonymous

Replying to knox:

I get the following error and dont know how whats wrong.

Shame on me! I just had to rebuild the egg from patched sources. Sorry for disturbing.

Add/Change #2612 (Port of SvnAuthzAdminPlugin to 0.11)




Change Properties
Action