Ticket #2830 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Main plugin page layout broken in Safari

Reported by: ryan@mindcandy.com Assigned to: osimons
Priority: normal Component: CustomFieldAdminPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

In Safari, the 'Add Custom Field' on the main page of the plugin, does not correctly float to the right of the list of custom fields - instead the list of custom fields appears beneath it.

As this worked fine in Firefox, checking the code with Firebug, I found that there is a missing </div> for the 'Add Custom Field' box which needs putting in to correct the layout problem.

The additional </div> should be placed after the existing </div> on line 77 of the 'customfieldadmin.cs' file.

Attachments

Change History

04/01/08 08:29:22 changed by osimons

Right, don't have a test setup for the 0.10 version anymore, but staring at the code it does look like a closing </div> is missing after line 68. Could you please test this change? 

Index: 0.10/customfieldadmin/templates/customfieldadmin.cs
===================================================================
--- 0.10/customfieldadmin/templates/customfieldadmin.cs	(revision 641)
+++ 0.10/customfieldadmin/templates/customfieldadmin.cs	(working copy)
@@ -66,6 +66,7 @@
    <legend>Add Custom Field:</legend>
    <div class="field">
     <label>Name:<br /><input type="text" name="name" id="name" /></label>
+   </div>
    <div class="field">
     <label>Type:<br /><select name="type" id="type">
     <option value="text">Text</option>

04/01/08 09:40:28 changed by ryan@mindcandy.com

  • status changed from new to closed.
  • resolution set to fixed.

Yes, that fixes it, thank you.

04/01/08 09:45:25 changed by osimons

(In [3428]) CustomFieldAdminPlugin Minor 0.10 template fix.

Closes #2830

Add/Change #2830 (Main plugin page layout broken in Safari)




Change Properties
Action