Ticket #3522 (assigned defect)

Opened 4 months ago

Last modified 2 months ago

Results from cross-project search show escaped html tags

Reported by: kenny Assigned to: anonymous (accepted)
Priority: normal Component: SearchAllPlugin
Severity: normal Keywords: escape characers html
Cc: Trac Release: 0.11

Description

When running the search on all projects, every result which is generated by the plugin looks similar to this: 

project1:<span class="closed">#17</span>: task: Some Task (closed: fixed)

The html <span> tags are still visible because they are escaped by Genshi to (from the html-sourcecode): 

<dt><a href="/trac/project1/ticket/17" class="searchable">project1: &lt;span class="closed"&gt;#17&lt;/span&gt;: task: Some Task (closed: fixed)</a></dt>

This display can be fixed by removing the literal string conversion from the searchall.py file and istead using the a "tag" object as return value.

Find attached a diff to show the required modifications.

Attachments

searchall.py.diff (0.5 kB) - added by kenny on 08/08/08 08:56:17.
Patch for searchall.py
searchall.py.2.diff (0.6 kB) - added by djs52 on 09/22/08 06:52:24.
Alternative patch which works with Trac 0.10

Change History

08/08/08 08:56:17 changed by kenny

  • attachment searchall.py.diff added.

Patch for searchall.py

08/15/08 10:07:03 changed by bobbysmith007

Just wanted to add a note that I applied this patch and it worked for me as well.

Russ

09/22/08 06:52:24 changed by djs52

  • attachment searchall.py.2.diff added.

Alternative patch which works with Trac 0.10

09/26/08 06:11:21 changed by anonymous

  • owner changed from airadier to anonymous.
  • status changed from new to assigned.

09/26/08 06:12:12 changed by airadier

Thanks, does the alternative patch work on both 0.10 and 0.11?

Add/Change #3522 (Results from cross-project search show escaped html tags)




Change Properties
Action