Ticket #592 (new defect)

Opened 2 years ago

Last modified 2 months ago

main navigation menu item is not highlighted when active

Reported by: anonymous Assigned to: otaku42
Priority: normal Component: NavAddPlugin
Severity: normal Keywords:
Cc: jashugan@gmail.com, nicolas.dumoulin@cemagref.fr Trac Release: 0.10

Description

The navigation menu items created by NavAddPlugin are not highlighted when they are active. For example, I added a "Open Ticket" menu item to the main navigation menu. After I click on the "Open Ticket" link in the main navigation, it is not highlighted. I expected it to be highlighted like for "Wiki" or "New Ticket" links.

I'm not sure how feasible this is to do. BTW, thanks for the great plugin!

Attachments

Change History

08/09/06 20:03:24 changed by anonymous

  • cc set to jashugan@gmail.com.

01/09/07 14:37:31 changed by sramij@yahoo.com

I agree, i faced the same problem exactly. how can i fix it, any solutions?

Thanks

01/09/07 14:38:26 changed by sramij@yahoo.com

  • priority changed from low to high.
  • release changed from 0.9 to 0.10.
  • severity changed from minor to major.

is there a patch which fix it? any suggestions?

05/18/07 00:46:20 changed by hihi

I have the same problem :( , It would be great to have that feature !

05/18/07 01:26:01 changed by otaku42

  • priority changed from high to normal.
  • severity changed from major to normal.

The buttons added by the plugin just link to other resources. Now imagine you add a button that links to /wiki/SomePage - how should the plugin (or Trac as a whole) know whether that page is visited by klicking on the button added by TracAddNav? instead of one of the other ways to reach that page?

I'm open for suggestions, but I currently don't see a way to do that.

05/18/07 02:59:32 changed by jashugan

Now imagine you add a button that links to /wiki/SomePage - how should the plugin (or Trac as a whole) know whether that page is visited by klicking on the button added by TracAddNav?? instead of one of the other ways to reach that page?

It doesn't matter to me how I reached that page. If it is highlighted when I'm on the page, then that will be sufficient. I am willing to test it out!

(follow-up: ↓ 8 ) 06/15/07 04:13:04 changed by Flignet

Why not add simply check if the xxx.title is equal to the current wiki page, if so highlight the button?

(in reply to: ↑ 7 ) 06/25/07 22:21:19 changed by otaku42

Replying to Flignet:

Why not add simply check if the xxx.title is equal to the current wiki page, if so highlight the button?

Because this will lead to false results when the button links, for example, to a wiki page. You will have two highlighted buttons then, the regular Wiki one, and the one added with NavAddPlugin linking to this page. In my eyes this would be quite misleading, thus I'm not confident with this solution.

10/09/08 06:05:29 changed by NicolasDumoulin

  • cc changed from jashugan@gmail.com to jashugan@gmail.com, nicolas.dumoulin@cemagref.fr.

A solution could be to give the ability to put in the "url" an traclinks rather than an url. I think it sould be possible to hook the active page with this method … maybe.

Add/Change #592 (main navigation menu item is not highlighted when active)




Change Properties
Action